From 1b521dba204e837838c7bce7e797f7a111b28cd0 Mon Sep 17 00:00:00 2001 From: Carlos Rodrigues Date: Fri, 29 May 2020 12:24:20 +0100 Subject: [PATCH] fix(compiler-core): generate the correct tree if comment is between if/else --- packages/compiler-core/src/parse.ts | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/packages/compiler-core/src/parse.ts b/packages/compiler-core/src/parse.ts index 5e526bc2f5f..f189233ddae 100644 --- a/packages/compiler-core/src/parse.ts +++ b/packages/compiler-core/src/parse.ts @@ -239,16 +239,15 @@ function parseChildren( } } - return removedWhitespace ? nodes.filter(Boolean) : nodes + const processedNodes = __DEV__ + ? nodes + : /// ignore comments in production check issue #1256 + nodes.filter(x => !x || x.type !== NodeTypes.COMMENT) + + return removedWhitespace ? processedNodes.filter(Boolean) : processedNodes } function pushNode(nodes: TemplateChildNode[], node: TemplateChildNode): void { - // ignore comments in production - /* istanbul ignore next */ - if (!__DEV__ && node.type === NodeTypes.COMMENT) { - return - } - if (node.type === NodeTypes.TEXT) { const prev = last(nodes) // Merge if both this and the previous node are text and those are