New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codeframe): Added Math.max to prevent RangeError (#1806) #1807

Merged

yyx990803 merged 1 commit into vuejs:master from jsmith:master

Aug 12, 2020

+5 −1

Contributor

jsmith commented Aug 7, 2020

When String(line).length (ie. when the source is >= 1000 lines), then range fails.

Closes #1806
Related to #1804 except this PR uses a max rather than abs.


          fix(codeframe): Added Math.max to prevent RangeError (vuejs#1806)

1b8465f

yyx990803 merged commit b14f4a5 into vuejs:master

yyx990803 mentioned this pull request

fix: output line more than 3 digits #1804

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet