Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(renderList): warn with v-for has non-integer range number #2247

Merged
merged 9 commits into from
Oct 13, 2020
+24 −0
Merged

feat(renderList): warn with v-for has non-integer range number #2247

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d22fe39
feat(renderList): `v-for` render non-integer range number
underfin Sep 27, 2020
40be0e7
fix: fix edge case
underfin Sep 27, 2020
253398a
refactor: warn for `v-for` has non-integer range value
underfin Sep 27, 2020
d5a975f
fix: remove ssr return value
underfin Sep 27, 2020
1bb6ec2
fix: remove unused test
underfin Sep 27, 2020
6aedbce
fix: use `Number.isInteger`
underfin Sep 27, 2020
a6ecfbe
fix: fix test
underfin Sep 27, 2020
4a0e512
fix: fix warn words
underfin Sep 27, 2020
7a70860
fix: better warn
underfin Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/runtime-core/__tests__/helpers/renderList.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ describe('renderList', () => {

it('should warn when given a non-integer N', () => {
renderList(3.1, () => {})
expect(
'Please give an non-integer value for v-for range.'
).toHaveBeenWarned()
expect('Please give an integer value for v-for range.').toHaveBeenWarned()
})

it('should render properties in an object', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime-core/src/helpers/renderList.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export function renderList(
}
} else if (typeof source === 'number') {
if (__DEV__ && !Number.isInteger(source)) {
warn('Please give an non-integer value for v-for range.')
warn('Please give an integer value for v-for range.')
return []
}
ret = new Array(source)
Expand Down
4 changes: 1 addition & 3 deletions packages/server-renderer/__tests__/ssrRenderList.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ describe('ssr: renderList', () => {

it('should warn when given a non-integer N', () => {
ssrRenderList(3.1, () => {})
expect(
'Please give an non-integer value for v-for range.'
).toHaveBeenWarned()
expect('Please give an integer value for v-for range.').toHaveBeenWarned()
})

it('should render properties in an object', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/server-renderer/src/helpers/ssrRenderList.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export function ssrRenderList(
}
} else if (typeof source === 'number') {
if (__DEV__ && !Number.isInteger(source)) {
warn('Please give an non-integer value for v-for range.')
warn('Please give an integer value for v-for range.')
underfin marked this conversation as resolved.
Show resolved Hide resolved
return
}
for (let i = 0; i < source; i++) {
Expand Down