From 908f61c5acd278638ce9f2da55b92bcc9d464a32 Mon Sep 17 00:00:00 2001 From: Thorsten Luenborg Date: Wed, 28 Oct 2020 11:52:20 +0100 Subject: [PATCH] fix(reactivity): ensure readonly on plain arrays doesn't track array methods. close: 2493 --- packages/reactivity/__tests__/readonly.spec.ts | 10 ++++++++++ packages/reactivity/src/baseHandlers.ts | 3 ++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/packages/reactivity/__tests__/readonly.spec.ts b/packages/reactivity/__tests__/readonly.spec.ts index ff73e43bcf7..b9edb440fb7 100644 --- a/packages/reactivity/__tests__/readonly.spec.ts +++ b/packages/reactivity/__tests__/readonly.spec.ts @@ -375,6 +375,16 @@ describe('reactivity/readonly', () => { expect(dummy).toBe(1) }) + test('readonly array should not track', () => { + const arr = [1] + const roArr = readonly(arr) + + const eff = effect(() => { + roArr.includes(2) + }) + expect(eff.deps.length).toBe(0) + }) + test('readonly should track and trigger if wrapping reactive original (collection)', () => { const a = reactive(new Map()) const b = readonly(a) diff --git a/packages/reactivity/src/baseHandlers.ts b/packages/reactivity/src/baseHandlers.ts index a246b6f3194..5f57a3c9f90 100644 --- a/packages/reactivity/src/baseHandlers.ts +++ b/packages/reactivity/src/baseHandlers.ts @@ -83,7 +83,8 @@ function createGetter(isReadonly = false, shallow = false) { } const targetIsArray = isArray(target) - if (targetIsArray && hasOwn(arrayInstrumentations, key)) { + + if (!isReadonly && targetIsArray && hasOwn(arrayInstrumentations, key)) { return Reflect.get(arrayInstrumentations, key, receiver) }