Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): optimization the logic of setting __props (close #2651) #2654

Closed
wants to merge 8 commits into from
Closed

fix(runtime-core): optimization the logic of setting __props (close #2651) #2654

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
20da7a6
fix(runtime-core): skip apply mixins if mixinOption is empty
edison1105 Nov 21, 2020
c22467e
fix(runtime-core): if raw is undefined should return null
edison1105 Nov 21, 2020
cfc9d6a
fix(runtime-core): if raw is undefined should return null
edison1105 Nov 21, 2020
8798660
fix(runtime-core): if normalized is empty should return null
edison1105 Nov 21, 2020
ac69362
fix(runtime-core): if normalized is empty should return null
edison1105 Nov 21, 2020
25b42b0
fix(runtime-core): if normalized is empty and !raw should return null
edison1105 Nov 21, 2020
69533b0
fix: add test case
edison1105 Nov 21, 2020
1ddea87
fix: do not set __props if !raw&&!hasExtends
edison1105 Nov 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/runtime-core/src/componentEmits.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,9 @@ export function normalizeEmitsOptions(
} else {
extend(normalized, raw)
}
return (comp.__emits = normalized)
// #2651 if normalized is empty and !raw should return null
return (comp.__emits =
!Object.keys(normalized).length && !raw ? null : normalized)
edison1105 marked this conversation as resolved.
Show resolved Hide resolved
}

// Check if an incoming prop key is a declared emit event listener.
Expand Down