fix(runtime-dom): skip set transitionProperty if has no cachedTransition #2714
Conversation
| @@ -163,9 +163,13 @@ export function resolveTransitionProps( | |||
| // the transition starts. This is applied for enter transition as well | |||
| // so that it accounts for `visibility: hidden` cases. | |||
| const cachedTransition = (el as HTMLElement).style.transitionProperty | |||
| ;(el as HTMLElement).style.transitionProperty = 'none' | |||
| if (cachedTransition) { | |||
There was a problem hiding this comment.
This way will reopen #2593, maybe a better way is needed to fixed both of issues.
There was a problem hiding this comment.
After add this code:
;(el as HTMLElement).style.transitionProperty = 'none'hasCSSTransform will be false
https://github.com/vuejs/vue-next/blob/d067fb2dbb82d9a653308baec40bb7f42322b705/packages/runtime-dom/src/components/TransitionGroup.ts#L60-L68
beacuse hasTransform will be false
https://github.com/vuejs/vue-next/blob/d067fb2dbb82d9a653308baec40bb7f42322b705/packages/runtime-dom/src/components/Transition.ts#L344-L346
if change the RegEx to:
/\b(transform|all|none)(,|$)/.test(styles[TRANSITION + 'Property']) will works fine.but this is bad solution.
I didn't figure out a better solution yet.
There was a problem hiding this comment.
I'm also trying to find a new solution.
There was a problem hiding this comment.
I'm not sure, but maybe a more acceptable solution #2716
There was a problem hiding this comment.
I'm not sure, but maybe a more acceptable solution #2716
Looks better.I will close this PR.
close #2712