fix(toRef): ref created from union typed prop can't be used in watch #3048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
approved these changes
Jan 18, 2021
posva
added
❗ p4-important
|
@pikax Can you have another look at this? Isue reminds me of similar issues with had with refs in compoisition api and Vue 3 beta/rc. Just to double-check. |
antfu
approved these changes
Feb 1, 2021
pikax
approved these changes
Feb 1, 2021
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
toRefmay create wrong type forwatchwhen prop is union typed.Reproduction:
https://codesandbox.io/s/wild-wood-vxm5j?file=/src/index.ts
Related Info:
https://www.typescriptlang.org/docs/handbook/2/conditional-types.html#distributive-conditional-types