docs(migration): provide guidance on using the new reactive currentRoute #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-router ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
posva
reviewed
Aug 30, 2023
niceplugin
added a commit
to niceplugin/Vuejs-Router-KO
that referenced
this pull request
Sep 17, 2023
niceplugin
added a commit
to niceplugin/Vuejs-Router-KO
that referenced
this pull request
Sep 17, 2023
* docs(migration): router.currentRoute (vuejs#1976) * docs: link to current Apache configuration (vuejs#1979) * docs: remove metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy folks,
Just raising this PR to add some extra guidance on the
currentRouteobject being changed to a reactive object in vue-router v4. We got a little tripped up on this during our migration to Vue 3/Vue-Router 4 as I couldn't find any docs that explicitly mentioned this change, and how it may impact code accessing router information from outside a Vue template.I'm hoping the place I've put it in is ok, but if its not, let me know and I'm happy to change it :)
Cheers,
Adam