fix: findComponent in Suspense for rc.11 #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuejs/core#2099 introduced a big refactoring in how Suspense works, which broke VTU. `SuspenseBoundary` no longer exposes the same interface, so our current implementation was not compiling anymore (and throwing at runtime). This solves the issue and simplifies the current code, as the newly introduced `activeBranch` field now contains the... active branch of the Suspense, so we just have to check that.
lmiller1990
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vuejs/core#2099 introduced a big refactoring in how Suspense works, which broke VTU.
SuspenseBoundaryno longer exposes the same interface, so our current implementation was not compiling anymore (and throwing at runtime).This solves the issue and simplifies the current code, as the newly introduced
activeBranchfield now contains the... active branch of the Suspense, so we just have to check that.