From b6f5c8f195c3f6f083352387638ad0ebf3c250f3 Mon Sep 17 00:00:00 2001 From: Pavan Kumar Sunkara Date: Tue, 25 Jun 2019 00:20:20 +0200 Subject: [PATCH 1/7] refactor: move router to it's own plugin --- packages/@vue/cli-plugin-router/.npmignore | 2 + packages/@vue/cli-plugin-router/README.md | 9 +++ .../generator}/index.js | 19 +----- .../generator/template/src/App.vue | 65 +++++++++++++++++++ .../generator}/template/src/router.js | 0 .../generator}/template/src/views/About.vue | 0 .../generator}/template/src/views/Home.vue | 0 packages/@vue/cli-plugin-router/index.js | 1 + packages/@vue/cli-plugin-router/package.json | 30 +++++++++ packages/@vue/cli-plugin-router/prompts.js | 13 ++++ .../__tests__/tsPluginE2e.spec.js | 2 +- .../generator/template/src/views/Home.vue | 4 +- .../@vue/cli-service/__tests__/serve.spec.js | 4 +- packages/@vue/cli-service/generator/index.js | 4 -- .../generator/template/src/App.vue | 59 +---------------- packages/@vue/cli-service/lib/PluginAPI.js | 3 +- .../cli-ui/apollo-server/api/PluginApi.js | 3 +- .../apollo-server/connectors/projects.js | 3 - .../@vue/cli-ui/ui-defaults/suggestions.js | 17 +++-- packages/@vue/cli/lib/Generator.js | 3 +- packages/@vue/cli/lib/add.js | 17 ----- packages/@vue/cli/lib/options.js | 3 - .../promptModules/__tests__/router.spec.js | 8 ++- packages/@vue/cli/lib/promptModules/router.js | 5 +- packages/@vue/cli/lib/util/features.js | 3 - .../@vue/cli/lib/util/inferRootOptions.js | 5 -- 26 files changed, 151 insertions(+), 131 deletions(-) create mode 100644 packages/@vue/cli-plugin-router/.npmignore create mode 100644 packages/@vue/cli-plugin-router/README.md rename packages/@vue/{cli-service/generator/router => cli-plugin-router/generator}/index.js (60%) create mode 100644 packages/@vue/cli-plugin-router/generator/template/src/App.vue rename packages/@vue/{cli-service/generator/router => cli-plugin-router/generator}/template/src/router.js (100%) rename packages/@vue/{cli-service/generator/router => cli-plugin-router/generator}/template/src/views/About.vue (100%) rename packages/@vue/{cli-service/generator/router => cli-plugin-router/generator}/template/src/views/Home.vue (100%) create mode 100644 packages/@vue/cli-plugin-router/index.js create mode 100644 packages/@vue/cli-plugin-router/package.json create mode 100644 packages/@vue/cli-plugin-router/prompts.js diff --git a/packages/@vue/cli-plugin-router/.npmignore b/packages/@vue/cli-plugin-router/.npmignore new file mode 100644 index 0000000000..e0b178a189 --- /dev/null +++ b/packages/@vue/cli-plugin-router/.npmignore @@ -0,0 +1,2 @@ +__tests__ +__mocks__ diff --git a/packages/@vue/cli-plugin-router/README.md b/packages/@vue/cli-plugin-router/README.md new file mode 100644 index 0000000000..05786ca865 --- /dev/null +++ b/packages/@vue/cli-plugin-router/README.md @@ -0,0 +1,9 @@ +# @vue/cli-plugin-router + +> router plugin for vue-cli + +## Installing in an Already Created Project + +``` sh +vue add @vue/router +``` diff --git a/packages/@vue/cli-service/generator/router/index.js b/packages/@vue/cli-plugin-router/generator/index.js similarity index 60% rename from packages/@vue/cli-service/generator/router/index.js rename to packages/@vue/cli-plugin-router/generator/index.js index 5fab3ccd8b..6f2db5321c 100644 --- a/packages/@vue/cli-service/generator/router/index.js +++ b/packages/@vue/cli-plugin-router/generator/index.js @@ -1,34 +1,19 @@ module.exports = (api, options = {}) => { api.injectImports(api.entryFile, `import router from './router'`) api.injectRootOptions(api.entryFile, `router`) + api.extendPackage({ dependencies: { 'vue-router': '^3.0.6' } }) + api.render('./template', { historyMode: options.routerHistoryMode, doesCompile: api.hasPlugin('babel') || api.hasPlugin('typescript') }) if (api.invoking) { - api.postProcessFiles(files => { - const appFile = files[`src/App.vue`] - if (appFile) { - files[`src/App.vue`] = appFile.replace(/^