feat(runtime-core): improve render context warning #2496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When we try to access a non-existing property on a component during rendering, we get this helpful warning:
However, the current implementation logs this warning as long as some component is currently rendering. In other words, the warning is not limited to the render cycle of the component instance that we tried to read the property from.
Solution
I think this warning should only be printed out during the component's own render.
Use case:
When reading a property from a child component instance obtained from a template ref, one might not know which kind of component the ref contains, so reading a prop in order to do a sort of duck typing is useful.
But with the current implementation, a warning would be logged to the console each time a child component is checked programmatically like this.