Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: init devtools in production #2906

Merged
merged 2 commits into from
Jan 5, 2021
Merged

fix: init devtools in production #2906

merged 2 commits into from
Jan 5, 2021

Conversation

underfin
Copy link
Member

No description provided.

@underfin underfin mentioned this pull request Dec 29, 2020
Closed
posva
posva reviewed Dec 29, 2020
View reviewed changes
packages/vue/src/index.ts Outdated Show resolved Hide resolved
@LinusBorg LinusBorg added the ready to merge The PR is ready to be merged. label Dec 31, 2020
@yyx990803 yyx990803 merged commit 4d9bcb7 into vuejs:master Jan 5, 2021
@underfin underfin deleted the production-devtools branch January 6, 2021 02:33
@andrewcourtice
Copy link

@LinusBorg @yyx990803

Just checking - is the __VUE_PROD_DEVTOOLS__ flag now required to be defined in production builds? Just ran a production build (using webpack) after bumping to v3.0.6 and this error came up.

image

I haven't defined the __VUE_PROD_DEVTOOLS__ global in my build config but that wasn't an issue up to v3.0.5. Should I always be defining this global or is this a regression in v3.0.6?

Cheers 👍

@yyx990803
Copy link
Member

yyx990803 commented Feb 24, 2021 •
edited
Loading

It was unintended - already fixed in d0ea745

For now the workaround is to explicitly define __VUE_PROD_DEVTOOLS__ (which is recommended anyway)

@andrewcourtice
Copy link

@yyx990803 Excellent! Thanks for the quick reply and fix 👍

This was referenced Mar 8, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva left review comments

@LinusBorg LinusBorg LinusBorg approved these changes

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@underfin @andrewcourtice @yyx990803 @posva @LinusBorg