Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beforeUnmount executes twice #3666

Closed
m0ksem opened this issue Apr 24, 2021 · 0 comments · Fixed by #3670
Closed

beforeUnmount executes twice #3666

m0ksem opened this issue Apr 24, 2021 · 0 comments · Fixed by #3670
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working

Comments

@m0ksem
Copy link

m0ksem commented Apr 24, 2021

Version

3.0.11

Reproduction link

https://codesandbox.io/s/flamboyant-star-vijce?file=/src/components/Separator.vue

Steps to reproduce

Go to the reproduction link.

Unmount list component

Look at console

What is expected?

BeforeUnmount executes one time for each Separator instance.

What is actually happening?

BeforeUnmount executes twice for the last Separator component.

Cause this problem: intlify/vue-i18n#476
@HcySunYang HcySunYang added 🐞 bug Something isn't working 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Apr 25, 2021
@HcySunYang HcySunYang mentioned this issue Apr 25, 2021
Merged
yyx990803 pushed a commit that referenced this issue May 27, 2021
@HcySunYang
fix(runtime-core): fix cases of reused children arrays in render func…
a641eb2 
…tions (#3670)

fix #3666
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(runtime-core): the component VNode should be cloned when reusing it
2 participants
@HcySunYang @m0ksem