Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server-renderer): compile templates on-the-fly #707

Merged
merged 7 commits into from
Feb 10, 2020

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Feb 8, 2020

I've got some questions about this:

  1. Should compiler be removable (server-renderer built w/o compiler, just as in Vue client renderer)?
  2. Should I rewrite existing SSR tests with templates to simplify them (except, of course, render/ssrRender ones)?

@dsseng dsseng changed the title feat(server-renderer): compile templates on-the-fly (WIP) feat(server-renderer): compile templates on-the-fly Feb 9, 2020
@dsseng dsseng marked this pull request as ready for review February 9, 2020 11:31
@dsseng dsseng requested a review from yyx990803 February 9, 2020 11:31
@yyx990803
Copy link
Member

Should compiler be removable (server-renderer built w/o compiler, just as in Vue client renderer)?

I don't think so since there are no size concerns for npm packages.

Should I rewrite existing SSR tests with templates to simplify them (except, of course, render/ssrRender ones)?

This is unnecessary - certain parts of the tests should be decoupled from the compiler.

packages/server-renderer/src/renderToString.ts Outdated Show resolved Hide resolved
packages/server-renderer/src/renderToString.ts Outdated Show resolved Hide resolved
packages/server-renderer/src/renderToString.ts Outdated Show resolved Hide resolved
packages/server-renderer/__tests__/renderToString.spec.ts Outdated Show resolved Hide resolved
@dsseng dsseng requested a review from yyx990803 February 10, 2020 15:46
@yyx990803 yyx990803 merged commit 6d10a6c into vuejs:master Feb 10, 2020
@dsseng dsseng deleted the feat/ssr-compile branch February 11, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants