-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal Vue crash: v-if on component #910
Comments
Using a component here is the key difference. If you do |
@yyx990803 The simple repro is fixed but I'm still having issues in my project. That said, this fragment: <ui-form
v-if="selected != null"
@save="updateGroup(selected)"
>
<!-- ... more stuff inside -->
<input
type="checkbox"
:value="right.name"
v-model="selected.roles"
style="margin-right: 12px;"
/> Still executes code with Exception is caught and if I let it run it then fails with a stack overflow: Any idea? |
Well... can't really tell anything without a repro. If you can maybe extract part of your project into something runnable, I can take a look. |
I'll try to see if I can come up with another repro... really not sure which bits are responsible for the problem after alpha.11 |
@yyx990803 I was working on other stuff and the bug went away with an unrelated change. Also can't exclude I was doing something stupid. Should it pop up again I'll try to find a repro but I'm giving up for now. |
@yyx990803 Got it. |
This fixes the case where a child component is added to the queue before its parent, but should be invalidated by its parent's update. Same logic was present in Vue 2. Properly fixes #910 ref: #910 (comment)
Version
3.0.0-alpha.10
Reproduction link
https://jsfiddle.net/3d2twLq9/1/
Steps to reproduce
Open the console, click on the button. Vue does some bad stuff.
What is expected?
v-if
is replaced byv-else
, no errorWhat is actually happening?
Stuff crashes, apparently because slot content is evaluated before
v-if
, which results innull
dereferences and then bad stuff.This minimal repro stays usable after the crash (you could set a new
some
value and recover).My own app is more complex and is unusable after this bug.
The text was updated successfully, but these errors were encountered: