Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(runtime-core): refactor defineComponent #1883

Merged
merged 28 commits into from
Sep 15, 2020
Merged

types(runtime-core): refactor defineComponent #1883

merged 28 commits into from
Sep 15, 2020

Conversation

pikax
Copy link
Member

@pikax pikax commented Aug 18, 2020 •
edited
Loading

Refactor defineComponent

Make it easier to retrieve component types:

declare function extractComponentOptions<Props, RawBindings>(
  obj: Component<Props, RawBindings>
): {
  props: Props
  rawBindings: RawBindings
  setup: ShallowUnwrapRef<RawBindings>
}

@pikax pikax marked this pull request as ready for review August 18, 2020 13:18
@pikax pikax changed the title types(runtime-core): move jsx defineComponent to jsx.d.ts types(runtime-core): refractor defineComponent Aug 18, 2020
@pikax pikax requested a review from yyx990803 August 20, 2020 11:21
@HcySunYang HcySunYang mentioned this pull request Aug 23, 2020
Merged
@pikax
Merge branch 'master-upstream' into types/move_jsx_types_to_jsx.d.ts
a669321 
# Conflicts:
#	packages/runtime-core/src/apiDefineComponent.ts
@posva posva changed the title types(runtime-core): refractor defineComponent types(runtime-core): refactor defineComponent Aug 31, 2020
@pikax pikax mentioned this pull request Sep 1, 2020
Closed
@yyx990803 yyx990803 merged commit 4fd468a into vuejs:master Sep 15, 2020
@pikax pikax deleted the types/move_jsx_types_to_jsx.d.ts branch September 15, 2020 15:47
@yyx990803 yyx990803 mentioned this pull request Sep 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
scope: types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pikax @yyx990803