fix(v-pre): do not alter attributes (fix #10087) #10088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
posva
requested changes
Jul 24, 2019
remove component and replace option from unit test
posva
approved these changes
Jul 25, 2019
| if (el.tagName.indexOf('-') > -1) { | ||
| baseSetAttr(el, key, value) | ||
| } else if(isInPre) { | ||
| if (el.tagName.indexOf('-') > -1 || isInPre) { |
There was a problem hiding this comment.
wouldn't checking isInPre first be more optimal?
posva
reviewed
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10087
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
When attributes under a v-pre match the list in
isBooleanAttr, the value is replaced. This goes against the purpose of v-pre which is to leave all elements as-is.An example of this bug can be found at https://jsfiddle.net/fp1omdaw/1/ as well as further details under #10087