fix(types): allow string for watch handlers #10396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
requested changes
Aug 14, 2019
types/options.d.ts
Outdated
| @@ -177,7 +177,7 @@ export interface WatchOptions { | |||
| } | |||
|
|
|||
| export interface WatchOptionsWithHandler<T> extends WatchOptions { | |||
| handler: WatchHandler<T>; | |||
| handler: WatchHandler<T> | string; | |||
There was a problem hiding this comment.
The WatchHandler type itself should include string as it appears in other places
There was a problem hiding this comment.
Moved it there @posva
posva
requested changes
Aug 14, 2019
posva
changed the title
|
@posva anything on my side to get this merged in? |
|
No, just waiting :) |
darielopper
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Adds missing TypeScript type info allowing watcher handler to be of
stringtype