-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle async placeholders in normalizeScopedSlot #11963
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
force-pushed
the
fix/async-scoped-slot
branch
from
March 16, 2021 12:45
08a391d
to
8b5ecaa
Compare
This was referenced Mar 16, 2021
pi0
force-pushed
the
fix/async-scoped-slot
branch
from
March 16, 2021 13:01
8b5ecaa
to
339f299
Compare
pi0
force-pushed
the
fix/async-scoped-slot
branch
from
March 16, 2021 13:05
339f299
to
e8c0248
Compare
posva
changed the title
fix: fix #10391, handle async placeholders in normalizeScopedSlot
fix: handle async placeholders in normalizeScopedSlot
Mar 24, 2021
posva
reviewed
Mar 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
posva
reviewed
Mar 24, 2021
Can we merge this in? I need this |
15 tasks
This was referenced Jun 2, 2021
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)Context: