Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle async placeholders in normalizeScopedSlot #11963

Merged
merged 3 commits into from
Apr 16, 2021

Conversation

pi0
Copy link
Contributor

@pi0 pi0 commented Mar 16, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

Context:

@pi0 pi0 force-pushed the fix/async-scoped-slot branch from 339f299 to e8c0248 Compare March 16, 2021 13:05
@posva posva changed the title fix: fix #10391, handle async placeholders in normalizeScopedSlot fix: handle async placeholders in normalizeScopedSlot Mar 24, 2021
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
@patrioticcow
Copy link

Can we merge this in? I need this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants