Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist/vue.esm.js 2.7.10 has mixed EOL - build is unstable #12819

Closed
mvorisek opened this issue Oct 8, 2022 · 1 comment
Closed

dist/vue.esm.js 2.7.10 has mixed EOL - build is unstable #12819

mvorisek opened this issue Oct 8, 2022 · 1 comment

Comments

@mvorisek
Copy link

mvorisek commented Oct 8, 2022

Version

2.7.10

Reproduction link

https://github.com/atk4/ui/tree/d896fec803b0dbb360ebe38b1514b675b934258f/js

Steps to reproduce

image

in atk4/ui framework we precompile and ship built JS files together with other changes

when we tried to upgrade from vue 2.6.14 to 2.7.10 we observed the EOL in the dist files is mixed

this is causing our builds to be unstable in environments where EOL git normalization is enabled

to fix the problem, please unify all EOL of text files to industry standard LF (no Windows CRLF)

once fixed, please issue a bugfix release, thanks!

What is expected?

all source text files has LF EOL

What is actually happening?

source files has mixed EOL, some lines are ended with LF, some with CRLF

@mvorisek
Copy link
Author

in dist/vue.esm.js there is still CRLF:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant