Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors not caught when thrown from directives #5314

Closed
blocka opened this issue Mar 29, 2017 · 1 comment
Closed

Errors not caught when thrown from directives #5314

blocka opened this issue Mar 29, 2017 · 1 comment
Labels
improvement

Comments

@blocka
Copy link

blocka commented Mar 29, 2017

Version

2.2.4

Reproduction link

https://jsfiddle.net/gL3f27eg/4/

Steps to reproduce

Run the darn thing

What is expected?

An alert saying "Caught error"

What is actually happening?

A console error with the exception
@LinusBorg
Copy link
Member

Thanks!

@javoski javoski mentioned this issue Mar 30, 2017
Merged
12 tasks
yyx990803 pushed a commit that referenced this issue Apr 3, 2017
@javoski @yyx990803
handle errors thrown by directive hooks (#5314) (#5324)
3c02655 
* handle errors thrown by directive hooks

* fix import
awamwang pushed a commit to awamwang/vue that referenced this issue Jun 15, 2017
@javoski @awamwang
handle errors thrown by directive hooks (vuejs#5314) (vuejs#5324)
582efea 
* handle errors thrown by directive hooks

* fix import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@blocka @yyx990803 @LinusBorg