Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support array syntax for keep-alive include and exclude #5956

Merged
merged 6 commits into from
Jun 30, 2017

Conversation

jkzing
Copy link
Member

@jkzing jkzing commented Jun 23, 2017

Support array syntax for keep-alive include and exclude. #5914

API looks like:

<keep-alive :include="['a', 'b', 'c']" :exclude="['foo']"></keep-alive>

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@Kingwl
Copy link
Member

Kingwl commented Jun 23, 2017

thanks for your PR!
and please add the test😃

@jkzing
Copy link
Member Author

jkzing commented Jun 23, 2017

Yes, sure...will do it later.
And will update related docs as well.

@jkzing jkzing changed the title Keep alive array Support array syntax for keep-alive include and exclude Jun 23, 2017
Copy link
Member

@Kingwl Kingwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants