Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Make set/delete warning condition for undefined, null and primitive values more precise. Corrects #7452 #7818

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

pkaminski
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Limiting set/delete to objects and arrays is overly restrictive; for example, there's no problem in setting properties on functions. I just changed the condition to what the original PR's description claimed and clarified the warning message.

@yyx990803 yyx990803 merged this pull request into vuejs:dev Mar 13, 2018
yyx990803 pushed a commit that referenced this pull request Mar 13, 2018
This was referenced Mar 14, 2018
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants