Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transition): transition-group should only listen for first-level children's end events #8374

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

verstoff
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

If in your list you have transitions on the nested elements, they will trigger the transitionend events that will cause finishing of transition-group's transition.

@posva
Copy link
Member

posva commented Jun 21, 2018

Could you provide a minimal repro of the bug please?

@verstoff
Copy link
Contributor Author

verstoff commented Jun 22, 2018

@posva
Sure: codesandbox repro

p.s.
Of course, in our app code we can subscribe on child's events and use stopPropagation as a workaround. But I think, <transition-group> should only affect direct descendants
Or at least this case can be documented somewhere

@posva posva removed the need repro label Jun 22, 2018
@posva
Copy link
Member

posva commented Jun 22, 2018

Thanks, now it is much clearer! This seems reasonable to me but could break some people work, so it would be interesting if there is any reasonable usage of nested elements transitions to trigger that transition-group. This is because, as you said, it's very easy to workaround the problem by adding @transitionend.stop to the nested element that also has a transition

@yyx990803 yyx990803 merged commit 504d5da into vuejs:dev Oct 24, 2018
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants