From 8dc947573c84acb0da321583a81dc074baf35aeb Mon Sep 17 00:00:00 2001 From: Phablulo Joel Date: Mon, 16 Jul 2018 02:05:45 -0300 Subject: [PATCH 1/2] update toMs function so it can parse floating numbers with commas instead of dots --- src/platforms/web/runtime/transition-util.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/platforms/web/runtime/transition-util.js b/src/platforms/web/runtime/transition-util.js index 47668f0c37d..ec8ee20c0b8 100644 --- a/src/platforms/web/runtime/transition-util.js +++ b/src/platforms/web/runtime/transition-util.js @@ -181,5 +181,5 @@ function getTimeout (delays: Array, durations: Array): number { } function toMs (s: string): number { - return Number(s.slice(0, -1)) * 1000 + return Number(s.slice(0, -1).replace(',', '.')) * 1000 } From 79c9c41f7966699ee03c7651c4fbec3c440a0478 Mon Sep 17 00:00:00 2001 From: Phablulo Joel Date: Mon, 16 Jul 2018 06:18:36 -0300 Subject: [PATCH 2/2] added comment to code --- src/platforms/web/runtime/transition-util.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/platforms/web/runtime/transition-util.js b/src/platforms/web/runtime/transition-util.js index ec8ee20c0b8..29c8c342199 100644 --- a/src/platforms/web/runtime/transition-util.js +++ b/src/platforms/web/runtime/transition-util.js @@ -180,6 +180,10 @@ function getTimeout (delays: Array, durations: Array): number { })) } +// Old versions of Chromium (below 61.0.3163.100) formats floating pointer numbers +// in a locale-dependent way, using a comma instead of a dot. +// If comma is not replaced with a dot, the input will be rounded down (i.e. acting +// as a floor function) causing unexpected behaviors function toMs (s: string): number { return Number(s.slice(0, -1).replace(',', '.')) * 1000 }