Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MdApp): add full height class #1254

Closed
wants to merge 2 commits into from
Closed

feat(MdApp): add full height class #1254

wants to merge 2 commits into from

Conversation

Samuell1
Copy link
Member

@Samuell1 Samuell1 commented Dec 3, 2017

@VdustR
Copy link
Member

VdustR commented Dec 3, 2017 •
edited
Loading

I think give it 100% and let them decide the height from outer is more flexible in my opinion.

In some case someone might stick an ad on top or the bottom, or split the screen up and down for another subpage.

@marcosmoura
Copy link
Member

I like both proposals. I think this should only come when we have the boilerplates.

@marcosmoura marcosmoura self-requested a review December 3, 2017 18:27
@Samuell1
Copy link
Member Author

Samuell1 commented Dec 3, 2017

It would be better to add prop like md-height and default will be 100vh ? @VdustR @marcosmoura

@VdustR
Copy link
Member

VdustR commented Dec 4, 2017

How about custom classes and style allowed?

https://github.com/VdustR/vue-material/commit/2a9fa0e2adf0560c13c8fde3d7dba284b0a8f933

@marcosmoura
Copy link
Member

@VdustR I liked it!

@Samuell1 Samuell1 closed this Dec 4, 2017
@Samuell1 Samuell1 deleted the feat/MdApp/add-full-height-class branch December 4, 2017 09:38
@VdustR VdustR mentioned this pull request Dec 4, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmoura marcosmoura Awaiting requested review from marcosmoura

Assignees

@Samuell1 Samuell1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Samuell1 @VdustR @marcosmoura