-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global error handler and renderer #309
Comments
worth noting: vuejs/vue#6953 (comment) |
According to the above comment, we have 2 kinds of errors - for simplicity, let's say, we have I was thinking about the shop having 'dev mode', so we could place those errors to some kind of a HTML container, and show it to the devs. In 'prod mode' tho, errors will not be shown, instead, they could be shown in console only. |
OK, i think for now we could make use of: https://stackoverflow.com/questions/31472439/catch-all-unhandled-javascript-promise-rejections and https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/onerror BUT it's need to be tested while offline because I'm affraid that elasticsearch-js is raising lot of errors when there is no ElasticSearch enabled which in our case is not an issue (we do have cachced data localy) To display error page with the details dumped to dev console in that case. I move it to 0.4 as it's not key for now |
* chore: add PR title check * chore: update action file * chore: remove config for gh action * chore: add config for gh app
https://medium.com/the-vue-point/vue-2-5-released-14bd65bf030b
The text was updated successfully, but these errors were encountered: