Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global error handler and renderer #309

Closed
pkarw opened this issue Nov 17, 2017 · 3 comments
Closed

Add global error handler and renderer #309

pkarw opened this issue Nov 17, 2017 · 3 comments
Labels
good first issue Tasks that requires just basic understanding of Vue Storefront

Comments

@pkarw
Copy link
Collaborator

pkarw commented Nov 17, 2017

https://medium.com/the-vue-point/vue-2-5-released-14bd65bf030b

@pkarw pkarw added the good first issue Tasks that requires just basic understanding of Vue Storefront label Nov 27, 2017
@pkarw pkarw added this to the 0.3.0 PoC with full off-line capabilities milestone Nov 30, 2017
@kacperknapik
Copy link
Collaborator

worth noting: vuejs/vue#6953 (comment)

@kacperknapik
Copy link
Collaborator

According to the above comment, we have 2 kinds of errors - for simplicity, let's say, we have DOM Event errors, and 'everything else'.
At the moment, DOM Event errors, exceptions, etc, are not handled at all, they are silent and we don't know about them. 'Everything else' tho, throws [Vue warn] ... to the console. (as far as I know)
Thanks to this new errorCaptured hook, we can do something more with those errors (not DOM Event ones), but the question is, what do we want to do with them exactly.

I was thinking about the shop having 'dev mode', so we could place those errors to some kind of a HTML container, and show it to the devs. In 'prod mode' tho, errors will not be shown, instead, they could be shown in console only.

@pkarw
Copy link
Collaborator Author

pkarw commented Nov 30, 2017

OK, i think for now we could make use of: https://stackoverflow.com/questions/31472439/catch-all-unhandled-javascript-promise-rejections

and

https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/onerror

BUT it's need to be tested while offline because I'm affraid that elasticsearch-js is raising lot of errors when there is no ElasticSearch enabled which in our case is not an issue (we do have cachced data localy)

To display error page with the details dumped to dev console in that case.

I move it to 0.4 as it's not key for now

@pkarw pkarw modified the milestones: 0.3.0 Taxes, User Accounts, Newsletter and fixes, 0.4.0 Customer's dashboard Nov 30, 2017
@pkarw pkarw modified the milestones: 0.4.0 Customer's dashboard , To Be Planned Dec 21, 2017
@pkarw pkarw closed this as completed Jan 24, 2018
@kacperknapik kacperknapik removed their assignment May 18, 2018
filrak pushed a commit that referenced this issue Apr 20, 2020
* chore: add PR title check

* chore: update action file

* chore: remove config for gh action

* chore: add config for gh app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Tasks that requires just basic understanding of Vue Storefront
Projects
None yet
Development

No branches or pull requests

2 participants