From e2f4f0ef5588689de332075acc391fa1f4952868 Mon Sep 17 00:00:00 2001 From: Mohib Arshi Date: Thu, 9 Nov 2023 19:25:20 +0530 Subject: [PATCH 1/2] fix(VBtn): prevent keyboard tab from triggering the loading button --- packages/vuetify/src/components/VBtn/VBtn.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/vuetify/src/components/VBtn/VBtn.tsx b/packages/vuetify/src/components/VBtn/VBtn.tsx index b45c3cc46c6..78df5f557aa 100644 --- a/packages/vuetify/src/components/VBtn/VBtn.tsx +++ b/packages/vuetify/src/components/VBtn/VBtn.tsx @@ -199,6 +199,7 @@ export const VBtn = genericComponent()({ props.style, ]} disabled={ isDisabled.value || undefined } + tabindex={ props.loading ? '-1' : undefined } href={ link.href.value } v-ripple={[ !isDisabled.value && props.ripple, From bbcca30348902872917225e0fe73dee4b19a61a0 Mon Sep 17 00:00:00 2001 From: John Leider Date: Thu, 28 Mar 2024 16:26:43 -0500 Subject: [PATCH 2/2] refactor(VBtn): change string tabindex to number, add aria-busy --- packages/vuetify/src/components/VBtn/VBtn.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/vuetify/src/components/VBtn/VBtn.tsx b/packages/vuetify/src/components/VBtn/VBtn.tsx index 78df5f557aa..34c876430bd 100644 --- a/packages/vuetify/src/components/VBtn/VBtn.tsx +++ b/packages/vuetify/src/components/VBtn/VBtn.tsx @@ -198,9 +198,10 @@ export const VBtn = genericComponent()({ sizeStyles.value, props.style, ]} + aria-busy={ props.loading ? true : undefined } disabled={ isDisabled.value || undefined } - tabindex={ props.loading ? '-1' : undefined } href={ link.href.value } + tabindex={ props.loading ? -1 : undefined } v-ripple={[ !isDisabled.value && props.ripple, null,