-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: remove wrapping element from detachable components #3206
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #3206 +/- ##
==========================================
+ Coverage 88.89% 89.19% +0.29%
==========================================
Files 227 207 -20
Lines 5376 4866 -510
Branches 1360 1225 -135
==========================================
- Hits 4779 4340 -439
+ Misses 479 420 -59
+ Partials 118 106 -12
Continue to review full report at Codecov.
|
@@ -3,6 +3,8 @@ import '../../stylus/components/_bottom-sheets.styl' | |||
import VDialog from '../VDialog/VDialog' | |||
|
|||
export default { | |||
functional: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know that u can't import functional components as Async Component (e.g. VDivider => import('path/to/VDivider.vue')). Server Renderer throw an error because component has no componentOptions
and Ctor
object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was fixed in 2.5.16: vuejs/vue#7784
functional components can have multiple root nodes, which allows us to render the dialog side-by-side with its activator
fe1bff7
to
bf028a6
Compare
590b80c
to
214e561
Compare
Re-open when this is seeing progress again. |
Description
Blocked by vuejs/vue#8350, only works with vue <2.5.16Motivation and Context
fixes #3205, fixes #3107
How Has This Been Tested?
Markup:
Types of changes
Checklist: