diff --git a/vulkano/src/buffer/allocator.rs b/vulkano/src/buffer/allocator.rs index ad1929cf30..88324584e4 100644 --- a/vulkano/src/buffer/allocator.rs +++ b/vulkano/src/buffer/allocator.rs @@ -252,13 +252,7 @@ where } /// Allocates a subbuffer with the given `layout`. - /// - /// # Panics - /// - /// - Panics if `layout.alignment()` exceeds `64`. pub fn allocate(&self, layout: DeviceLayout) -> Result, MemoryAllocatorError> { - assert!(layout.alignment().as_devicesize() <= 64); - unsafe { &mut *self.state.get() }.allocate(layout) } } diff --git a/vulkano/src/buffer/mod.rs b/vulkano/src/buffer/mod.rs index 46ee00435a..14340a674e 100644 --- a/vulkano/src/buffer/mod.rs +++ b/vulkano/src/buffer/mod.rs @@ -376,14 +376,12 @@ impl Buffer { /// # Panics /// /// - Panics if `create_info.size` is not zero. - /// - Panics if `layout.alignment()` is greater than 64. pub fn new( allocator: Arc, mut create_info: BufferCreateInfo, allocation_info: AllocationCreateInfo, layout: DeviceLayout, ) -> Result, Validated> { - assert!(layout.alignment().as_devicesize() <= 64); // TODO: Enable once sparse binding materializes // assert!(!allocate_info.flags.contains(BufferCreateFlags::SPARSE_BINDING)); diff --git a/vulkano/src/buffer/subbuffer.rs b/vulkano/src/buffer/subbuffer.rs index 3bc2710097..77accb1ce7 100644 --- a/vulkano/src/buffer/subbuffer.rs +++ b/vulkano/src/buffer/subbuffer.rs @@ -300,6 +300,8 @@ where /// [`SubbufferAllocator`]: super::allocator::SubbufferAllocator /// [`RawBuffer::assume_bound`]: crate::buffer::sys::RawBuffer::assume_bound pub fn read(&self) -> Result, HostAccessError> { + assert!(T::LAYOUT.alignment().as_devicesize() <= 64); + let allocation = match self.buffer().memory() { BufferMemory::Normal(a) => a, BufferMemory::Sparse => todo!("`Subbuffer::read` doesn't support sparse binding yet"), @@ -391,6 +393,8 @@ where /// [`SubbufferAllocator`]: super::allocator::SubbufferAllocator /// [`RawBuffer::assume_bound`]: crate::buffer::sys::RawBuffer::assume_bound pub fn write(&self) -> Result, HostAccessError> { + assert!(T::LAYOUT.alignment().as_devicesize() <= 64); + let allocation = match self.buffer().memory() { BufferMemory::Normal(a) => a, BufferMemory::Sparse => todo!("`Subbuffer::write` doesn't support sparse binding yet"),