Fixed potential overflow in multiview vertex buffer validation #1855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a potential integer overflow in the "valid" path of multiview vertex buffer validation when
max_instance_index
equalsu32::MAX
. In this case, the additionmax_instance_index + 1
on the right-hand side of the comparison overflows even for valid cases. The potential overflow in the error path (already marked "TODO") is not fixed by this.I got hit by this issue when trying to run the multiview example on a Radeon 6700 XT with the amdgpu driver. The MESA driver apparently returns i32::MAX for
max_instance_index
and so it doesn't cause this overflow.