-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to manual management of descriptor set and command buffer allocators #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc0246
force-pushed
the
master
branch
2 times, most recently
from
October 4, 2022 05:08
3f975f7
to
30ec12b
Compare
It all works and looks good. It will be a big change for Vulkano, so hopefully there's no hidden bugs and users won't be too confused by it. |
Agreed. I would have preferred to keep this automatic, but in the end this will be both faster and more flexible for the user, so hopefully people will take kindly to it. |
marc0246
added a commit
to marc0246/vulkano
that referenced
this pull request
Oct 6, 2022
marc0246
added a commit
to marc0246/vulkano
that referenced
this pull request
Oct 7, 2022
Rua
pushed a commit
that referenced
this pull request
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
In two of my previous PRs I addressed some performance concerns around the standard implementations of (then) descriptor and command pools. One of the optimizations involved removing the layer of
Mutex
that was used to store these pools inside the device. My idea was to use thread-local storage as a solution with almost no overhead that would also work as conveniently as before, but after some discussion on Discord it was pointed out that in certain edge-cases, the TLS might keepDevice
s alive that have already been dropped by the user. Because of that, putting the burden of managing these (then) pools onto the user seems inevitable, otherwise we would have to sacrifice some of the performance gains for a bit of convenience.Other than that, the "pool" and co. types have been renamed to hopefully be less confusing to someone coming from Vulkan, as they function quite differently. Also,
AutoCommandBufferBuilder
can now be constructed using arbitrary implementations ofCommandBufferAllocator
.I have tried to do
StandardMemoryPool
in this PR as well, but quickly realized thatCpuBufferPool
wasn't made with manually-managed memory allocators in mind, so I decided to do that in an upcoming PR together with my revamp of memory allocation in vulkano.