Add support for acceleration structures and ray queries #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acceleration-structure
marc0246
reviewed
Jun 2, 2023
|
I see you named all the new |
marc0246
reviewed
Jun 2, 2023
marc0246
reviewed
Jun 2, 2023
Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
…acceleration-structure
|
All LGTM, thanks so much! 🎉 |
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
) * Add support for acceleration structures and ray queries * Add support for acceleration structures and ray queries * Add add_context helper method * Remove Option from ValidationError::requires_one_of * Update vulkano/src/command_buffer/commands/bind_push.rs Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com> * Use id counter, small clippy fixes elsewhere * Use byte buffers for things with strides --------- Co-authored-by: marc0246 <40955683+marc0246@users.noreply.github.com>
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
This finally adds support for acceleration structures and ray queries! It's a pretty big addition, with a lot of potential for errors, so I hope that people will try it out and help test it before 0.34 is released. There's a lot of
unsafehere, because many things rely on data in device buffers that Vulkano can't check.The acceleration structure extension also includes support for executing AS operations on the host instead of the device. But I decided not to implement those, because very few drivers actually support it at the moment, so it would be impossible to test.