Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the now-stabilized pointer_bytes_offsets instead of what is technically UB and clean up the BufferContents derive macro expansion #2563

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

marc0246
Copy link
Contributor

@marc0246 marc0246 commented Sep 9, 2024

The old derive expansion assumed slice pointer layout, and although it is surely getting defined soon, it's still better to get rid of it now that it's possible because pointer_bytes_offsets has been stabilized for long enough, as the old expansion was UB. This also cleans up the expansion by moving more of the code into the library so that it's easier to catch bugs and to look at the expansion.

Changelog:

### Public dependency updates
- Rust version: 1.75.0

@marc0246 marc0246 force-pushed the derive-buffercontents branch from 33992c2 to 5024e3b Compare September 9, 2024 11:18
@marc0246 marc0246 force-pushed the derive-buffercontents branch from 5024e3b to 405baa2 Compare September 9, 2024 11:22
@Rua Rua merged commit f508cab into vulkano-rs:master Sep 12, 2024
6 checks passed
Rua added a commit that referenced this pull request Sep 12, 2024
@marc0246 marc0246 deleted the derive-buffercontents branch September 12, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants