Use the now-stabilized pointer_bytes_offsets
instead of what is technically UB and clean up the BufferContents
derive macro expansion
#2563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old derive expansion assumed slice pointer layout, and although it is surely getting defined soon, it's still better to get rid of it now that it's possible because
pointer_bytes_offsets
has been stabilized for long enough, as the old expansion was UB. This also cleans up the expansion by moving more of the code into the library so that it's easier to catch bugs and to look at the expansion.Changelog: