Return all addresses in ListAddresses & Fix Transfer rpc #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this the account service was returning only external addresses when listing all for an account. Now it returns internal addresses too.
This also fixes the Transfer rpc by letting one to transfer all balance from an account by deducting network fees instead of assign them to the transferred amount as usually done.
Last but not least, this updates the Input message type by adding new fields that will help with the estimation of a tx with p2sh/p2sh(p2wsh)/p2wsh/p2tr inputs.
Please @tiero review.