Support watching custom scripts #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 2 new unary rpcs to the notification service to start/stop watching output scripts. The rpcs can be used without having to create and unlock the wallet. Notifications about txs and utxos can be received through the already existing server-side stream rpcs.
To add the above feature, this adds a new domain
ExternalScriptrepresented by the already existingAddressInfoand the relative repository.Every script is identified by its scripthash as defined by electrumx to prevent any possible collision between different scripts.
The user can also pass the blinding private key so that ocean can unblind any confidential output, if any is going to be locked by the given script.
BONUS: This fixes unsubscribing for scripts/account. Before this, ocean would crash if it received a notification from electrum about a deleted script/account.
Please @louisinger review.