add OSX docker support

[joshughes]

This resolves #16

In the case when executing serverspec on OSX vagrant-serverspec will now proxy ssh commands through the boot2docker host vagrant creates to the container. It only does this on OSX so linux functionality where docker is running on the same machine as vagrant should be unaffected.

[tehmaspc]

+1

[vvchik]

Hi @joshughes thank you for your PR, may also add some little instruction to Readme for OSX users?
Also do you have possibility to test it under linux docker to be sure?

[joshughes]

@vvchik Sorry I missed your comment. Basically the serverspec plugin already works for linux because there is not jumphost to ssh proxy through. OSX docker MUST run in an VM. Vagrant handles this by spinning up an VM in virtualbox that has the docker host installed. Basically my patch finds that host and ssh's into that host before sshing into the actual docker container.

There is not special configuration needed for OSX or Linux for my patch to work... If the users have followed the instructions on how to use the Vagrant Docker provider, with my patch the serverspec plugin will simply just work, like it does for AWS, Virtualbox and others. So Docker on OSX and Windows is a special case since the Docker host is on a VM so we have to use an SSH proxy host.

I can write up an explanation in the README if you like... but the idea of the patch was that serverspec would just work, like it does for most providers at the moment. Just let me know what information you would like included.

[jvoorhis]

Hi @joshughes,

It would be great if we can add a note about this to the README.

[joshughes]

@jvoorhis I added a note to the readme with the basic explanation on why the ssh proxy is needed, and a reference to this pull request in case anyone in the future wants to look at the exact code that handles the ssh proxy.

[joshughes]

@jvoorhis ANything else I can do to get this merged?

[joshughes]

@jvoorhis do you have any time to merge this PR?

[vvchik]

I may merge it, but it will not update it on rubygems.

[joshughes]

Any reason why you don't want to do a release to rubygems? @vvchik

[bayendor]

+1, this would definitely help.

[vvchik]

@joshughes I don't have rights to do it :)

[joshughes]

@vvchik who has the rights?

[jvoorhis]

@vvchik can you confirm your rubygems.org handle in the thread? I'd be happy to add you as a project owner.

[vvchik]

Vvchik, same as here :)

[jvoorhis]

Great, I've added you as an owner of the rubygem.

On Mon, Aug 10, 2015 at 12:38 PM, Volodymyr Babchynskyy <
notifications@github.com> wrote:

Vvchik, same as here :)

—
Reply to this email directly or view it on GitHub
#17 (comment)
.

Jeremy Voorhis

[vvchik]

I`ve added latest version to rubygems
so @joshughes you may use it in standard way via vagrant plugin install