Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thorough Review should mention technical soundness #170

Closed
cynthia opened this issue Apr 9, 2024 · 1 comment
Closed

Thorough Review should mention technical soundness #170

cynthia opened this issue Apr 9, 2024 · 1 comment
Labels
needed for Statement Probably needs to be resolved prior to Statement vote Project Vision Vision and Principles

Comments

@cynthia
Copy link
Member

cynthia commented Apr 9, 2024

In the items listed in Thorough Review, we mention all of the wide review aspects. I wonder if we should add something around "technically sound" in it.

The core of a TAG design review is around ensuring us not shipping bad technical solutions, and the other aspects don't capture that well (e.g. API soundness, ergonomics, consistency/interoperability with other APIs).

CC: @wareid @torgo @plinss
@koalie koalie added the Project Vision Vision and Principles label Apr 9, 2024
@fantasai fantasai added the needed for Statement Probably needs to be resolved prior to Statement vote label Sep 25, 2024
fantasai added a commit to fantasai/AB-public that referenced this issue Sep 25, 2024
@fantasai
[Vision] Add technical soundness and architectural integrity to Thoro…
20fde02 
…ugh Review w3c#170 w3c#141
@fantasai fantasai mentioned this issue Sep 25, 2024
Merged
fantasai added a commit to fantasai/AB-public that referenced this issue Sep 27, 2024
@fantasai
[Vision] Add technical soundness and architectural integrity to Thoro…
919d995 
…ugh Review w3c#170 w3c#141
cwilso pushed a commit that referenced this issue Sep 27, 2024
@fantasai
[Vision] Add technical soundness and architectural integrity to Thoro…
3ca3f10 
…ugh Review #170 #141 (#173)
@fantasai fantasai mentioned this issue Sep 27, 2024
Open
@cwilso
Copy link
Collaborator

cwilso commented Sep 27, 2024

Resolved by #173 .

@cwilso cwilso closed this as completed Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needed for Statement Probably needs to be resolved prior to Statement vote Project Vision Vision and Principles
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cynthia @cwilso @fantasai @koalie