Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add technical soundness and architectural integrity to Thorough Review #173

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

fantasai
Copy link
Contributor

@fantasai fantasai commented Sep 25, 2024

Addresses #170 #141


Preview | Diff

@cwilso
Copy link
Collaborator

cwilso commented Sep 25, 2024

I would rather view this as #170 fixes #141, and only mention "technical soundness".

@fantasai
Copy link
Contributor Author

@cwilso I'm not sure I understand your comment, but I think these are two different (certainly related) things:

  • technical soundness is something we ensure through the deep review that happens through our WG discussions, and through our implementation experience requirements -- ensuring out specs are thorough, detailed, well-thought out
  • architectural integrity is about ensuring the whole system hangs together, and we do it mainly through TAG review and that kind of thing

We do both, and both are valuable, but they are distinct; so that's why I kept them distinct in the PR.

Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon deeper reflection and a bit of research of prior wording of these things at W3C (multiple sources), I have edited the PR to a single line to encapsulate both in a shorter phrase that has established use at W3C.

I do agree with the use-cases / motivations in both issues @fantasai has mentioned and believe this edit now reinforces and resolves both.

@tantek tantek requested a review from cwilso September 26, 2024 00:44
@fantasai
Copy link
Contributor Author

fantasai commented Sep 26, 2024

@tantek I don't think folding to "technical architecture" encompasses both, because you can have good architecture and sloppy details. As I outlined in #173 (comment) we really do explicitly review for both.

@fantasai
Copy link
Contributor Author

[reverted to the original commit; please don't edit someone else's PR, it's very weird to have one's proposal unilaterally replaced with someone else's proposal]

@tantek
Copy link
Member

tantek commented Sep 27, 2024

[reverted to the original commit; please don't edit someone else's PR, it's very weird to have one's proposal unilaterally replaced with someone else's proposal]

Sorry this was me being clumsy with GitHub UI and attempting to suggest edits to a PR and clicking the wrong series of buttons / not understanding what I was doing. :/

Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest placing these additions at end of that list, both per cited examples, and perhaps more importantly following some of the priority of constituencies:

  • users (a11y, i18n, s12y, privacy, security)
  • over implementers (technical soundness)
  • over theoretical purity (architectural integrity).

Vision/Vision.bs Outdated Show resolved Hide resolved
Vision/Vision.bs Outdated Show resolved Hide resolved
Vision/Vision.bs Outdated Show resolved Hide resolved
@fantasai
Copy link
Contributor Author

@tantek Done!

@cwilso cwilso merged commit 3ca3f10 into w3c:main Sep 27, 2024
2 checks passed
@fantasai fantasai deleted the technical branch September 27, 2024 18:36
@tantek tantek added the Project Vision Vision and Principles label Sep 30, 2024
@tantek tantek changed the title [Vision] Add technical soundness and architectural integrity to Thorough Review Add technical soundness and architectural integrity to Thorough Review Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project Vision Vision and Principles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants