Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Fetch "shift+reload" #952

Open
annevk opened this issue Aug 12, 2016 · 4 comments
Open

Handle Fetch "shift+reload" #952

annevk opened this issue Aug 12, 2016 · 4 comments

Comments

@annevk
Copy link
Member

annevk commented Aug 12, 2016

This could use more formal language. Not entirely sure what to suggest, but hardcoding keys isn't the way to go.

@NekR
Copy link

NekR commented Aug 19, 2016

  • Hard Reload
  • Force Reload

Probably something else..

@annevk
Copy link
Member Author

annevk commented Aug 20, 2016

You prolly want to describe the effect of the action more than the way to achieve. And then mention a common or encouraged way to achieve it in a note.

@jakearchibald
Copy link
Contributor

We could hook into the cache mode of the navigation request. This would be easier if the navigation part of the HTML spec made reference to this feature.

@wanderview
Copy link
Member

We could hook into the cache mode of the navigation request. This would be easier if the navigation part of the HTML spec made reference to this feature.

We used to do this and had to explicitly stop doing it. We ran into situations where developers would use addons or devtools to bypass http cache. In these cases they did not expect their service workers to stop working.

We have a separate set of flags we look for:

https://dxr.mozilla.org/mozilla-central/source/docshell/base/nsDocShellLoadTypes.h#105

That are essentially set explicitly up in the UX layer for various things:

https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#1792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants