From 0ba3c1c20a1bc37f40f62d0f6f7e31362e814e61 Mon Sep 17 00:00:00 2001 From: Jon Gunderson Date: Thu, 11 Jul 2019 02:09:54 -0500 Subject: [PATCH] Image Carousel Example: Use buttons for controls and make rotation control always visible (pull #1018) Resolves issue #1007 by: * making the stop/start rotation button always visible. * Using button elements instead of links for the next and previous slide controls. Also: * Allows user to change between 2 view options: one with controls and captions overlayed on the images and one with them outside the image frames. * Improves documentation in the accessibility features section. * Adds regression tests. --- aria-practices.html | 5 - .../carousel/{carousel-1 => }/carousel-1.html | 218 +++++++++-------- examples/carousel/carousel-1/css/carousel.css | 176 -------------- .../carousel/carousel-1/js/pauseButton.js | 38 --- .../css/carousel-1-more-accessible.css | 185 +++++++++++++++ examples/carousel/css/carousel-1.css | 165 +++++++++++++ .../images/amsterdamslide__800x600.jpg | Bin .../images/britcomdavidslide__800x600.jpg | Bin .../images/foyleswarslide__800x600.jpg | Bin .../images/lands-endslide__800x600.jpg | Bin .../images/mag800-2__800x600.jpg | Bin .../images/trustslide-2__800x600.jpg | Bin .../carousel/{carousel-1 => }/js/carousel.js | 89 +++---- .../{carousel-1 => }/js/carouselButtons.js | 25 +- .../{carousel-1 => }/js/carouselItem.js | 4 +- examples/carousel/js/pauseButton.js | 22 ++ test/tests/carousel-1.js | 224 ++++++++++++++++-- 17 files changed, 740 insertions(+), 411 deletions(-) rename examples/carousel/{carousel-1 => }/carousel-1.html (65%) delete mode 100644 examples/carousel/carousel-1/css/carousel.css delete mode 100644 examples/carousel/carousel-1/js/pauseButton.js create mode 100644 examples/carousel/css/carousel-1-more-accessible.css create mode 100644 examples/carousel/css/carousel-1.css rename examples/carousel/{carousel-1 => }/images/amsterdamslide__800x600.jpg (100%) rename examples/carousel/{carousel-1 => }/images/britcomdavidslide__800x600.jpg (100%) rename examples/carousel/{carousel-1 => }/images/foyleswarslide__800x600.jpg (100%) rename examples/carousel/{carousel-1 => }/images/lands-endslide__800x600.jpg (100%) rename examples/carousel/{carousel-1 => }/images/mag800-2__800x600.jpg (100%) rename examples/carousel/{carousel-1 => }/images/trustslide-2__800x600.jpg (100%) rename examples/carousel/{carousel-1 => }/js/carousel.js (68%) rename examples/carousel/{carousel-1 => }/js/carouselButtons.js (73%) rename examples/carousel/{carousel-1 => }/js/carouselItem.js (93%) create mode 100644 examples/carousel/js/pauseButton.js diff --git a/aria-practices.html b/aria-practices.html index 48c1357acd..bec55e76ee 100644 --- a/aria-practices.html +++ b/aria-practices.html @@ -480,11 +480,6 @@

WAI-ARIA Roles, States, and Properties