Add tests for button/button.html #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spectranaut
force-pushed
the
bocoup-button
branch
from
ead2d88 to
de6a5f3
Compare
|
@jessebeach, @tatermelon, @sh0ji, even though travis is failing, this is ready for review. The failures are related to a race condition that is not specific to these tests. @spectranaut is debugging the failures separately. |
jessebeach
approved these changes
Aug 28, 2018
There was a problem hiding this comment.
@spectranaut you are going to be the foremost expect of accessible components in the world ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.