Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-overflow] add overflow-block and overflow-inline to support CSS Writing Modes #2000

Closed
a2sheppy opened this issue Nov 20, 2017 · 11 comments
Assignees
Labels
Closed Accepted by CSSWG Resolution Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-overflow-3 Current Work

Comments

@a2sheppy
Copy link

Currently, neither css-overflow (https://drafts.csswg.org/css-overflow) nor css-logical (https://drafts.csswg.org/css-logical/) define a method for specifying values for the overflow property based on the current writing direction. Instead, you can only specify the overflow in terms of the X and Y axes. This is highly limiting when trying to adapt to a multi-locale environment where you may need to set overflow based on the direction of text flow.

Either in css-overflow or in css-logical (whichever is appropriate), there should be a definition for how to set overflow based on the text flow rather than strict X/Y directions.

@Loirooriol
Copy link
Contributor

It would also be nice if overflow accepted two keywords (one for each physical direction) and optionally a flow-relative switch (see #1282).

@a2sheppy
Copy link
Author

Obviously per the title of this issue, I think adding overflow-block and overflow-inline properties to CSS makes sense, given how other related properties are handled.

I agree though that supporting a syntax like the following would also be helpful:

overflow: relative? && [ <length> | <percentage> | auto ]{1,2}

(or logical instead of relative, whichever is settled upon in the end elsewhere in CSS-land)

@frivoal
Copy link
Collaborator

frivoal commented Dec 14, 2017

Seems to me that this should go into css-logical (1 or 2, I don't care strongly). @fantasai @atanassov what do you think?

As for adding the relative or logical, I think it would be weird to do it only for overflow, and not for other shorthand properties that can have either physical or logical longhands. @a2sheppy, do you want to open a separate issue about that, or do you think there is a reason why this would need to exist for this but not for other properties?

@Loirooriol
Copy link
Contributor

@frivoal I think nobody suggested adding a flow-relative switch only for overflow. It's just that if flow-relative longhands are added for overflow, overflow syntax is changed to accept two values, and a flow-relative switch is added in #1282, then the switch should also work in overflow.

@frivoal
Copy link
Collaborator

frivoal commented Dec 15, 2017

@Loirooriol I see, sorry for the misunderstanding. In that case, yes, I agree, and the only question left for me is which spec the logical longhands of overflow go to. I'd suggest css-logical over css-overflow, but I'm not stuck on that.

@a2sheppy
Copy link
Author

@frivoal I'm not sure which spec the logical longhands belong in either, although I think I lean toward css-logical as well. I'll file a ticket there and let y'all sort things out. :)

@a2sheppy
Copy link
Author

Actually, does issue #1282 already address this? It refers to margin but seems to be just using it as an example (since it says "margin-like" shorthands. Would that not include overflow?

@frivoal
Copy link
Collaborator

frivoal commented Dec 18, 2017

@a2sheppy #1282 works for the addtion of the relative keyword, and this ticket works for the addition of the logical long hand. We're just waiting for an upcoming CSS-WG teleconference call to decide whether we agree (I expect we will), and which spec we put it in (I expect css-logical).

@dbaron
Copy link
Member

dbaron commented Jan 10, 2018

I think it should go in whichever of css-overflow or css-logical is the less stable specification. I think that's currently css-logical, but I'm not confident of that judgment.

@fantasai
Copy link
Collaborator

It should go into css-overflow-3; css-logical-1 only defines stuff in earlier modules (e.g. CSS2.1), newer ones are expected to define their own logical equivalents. (I can't say that css-logical-1 and css-overflow-3 are particularly different wrt stability anyway. They both should be in CR, but need a bit of work / trimming down to get there.)

@css-meeting-bot
Copy link
Member

The Working Group just discussed [css-overflow] add overflow-block and overflow-inline to support CSS Writing Modes, and agreed to the following resolutions:

  • RESOLVED: add the writing direction dependant overflow values into CSS Overflow 3
The full IRC log of that discussion <dael> Topic: [css-overflow] add overflow-block and overflow-inline to support CSS Writing Modes
<dael> github: https://github.com//issues/2000
<dael> fantasai: I think adding these properties makes a lot of sense. Just nee WG approval. I believe they should go into CSS Overflow L3.
<dael> Rossen_: I'm also in favor of this.
<dael> Rossen_: As to the draft...css logical is fine.
<dael> Rossen_: We currently have attempted to spec a bunch of properties with their logical behavior inside CSS Logical. That's kinda where we attempted to put all lgocial directions.
<dael> fantasai: That spec is b/c for most properties...they were in CSS 2.1 and there wasn't a css 3 draft with those properties. For scroll snap, though we put logical eq. in an appendix in spec.
<dael> Rossen_: Borders?
<dael> fantasai: Yeah, L3 was stabilized a long time ago so we couldn't change. L4 is expected to include logical keywords.
<dael> fantasai: Grid and Flexbox don't have physical eq.
<dael> Rossen_: So we can close I"m in favor of adding a spec fot he requested behavior. If this lives in overflow 3...yeah...css overflow 3 seems the better place.
<dael> astearns: Are you okay with L3 dbaron ?
<dael> dbaron: That makes overflow 3 depend on logical. As long as that's not an obstical I'm okay.
<dael> Rossen_: How about we deal with it when we get to it. WE see which pulls ahead. My intuition is logical is a bit of work, but not that much.
<dael> astearns: I'm in favor of putting it where it makes sense and if the race makes it problmeatic then we can deal with it. Predictions on spec progress are often wrong.
<dael> astearns: prop: add the writing direction dependant overflow values into CSS Overflow 3
<dael> astearns: Obj?
<dael> RESOLVED: add the writing direction dependant overflow values into CSS Overflow 3

dbaron pushed a commit to web-platform-tests/wpt that referenced this issue Mar 29, 2018
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Apr 15, 2018
…overflow properties, a=testonly

Automatic update from web-platform-tests[css-overflow-3] test the flow-relative overflow properties (#10233)

Corresponding to the spec changes decided in w3c/csswg-drafts#2000

wpt-commits: 4091ab0f7cbcb304cdd5b1d1c30264b052359b38
wpt-pr: 10233
wpt-commits: 4091ab0f7cbcb304cdd5b1d1c30264b052359b38
wpt-pr: 10233
fergald pushed a commit to fergald/csswg-drafts that referenced this issue May 7, 2018
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 2, 2019
…overflow properties, a=testonly

Automatic update from web-platform-tests[css-overflow-3] test the flow-relative overflow properties (#10233)

Corresponding to the spec changes decided in w3c/csswg-drafts#2000

wpt-commits: 4091ab0f7cbcb304cdd5b1d1c30264b052359b38
wpt-pr: 10233
wpt-commits: 4091ab0f7cbcb304cdd5b1d1c30264b052359b38
wpt-pr: 10233

UltraBlame original commit: 5b9ca0964cc4e29979c283b453faa08ffeb62226
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 2, 2019
…overflow properties, a=testonly

Automatic update from web-platform-tests[css-overflow-3] test the flow-relative overflow properties (#10233)

Corresponding to the spec changes decided in w3c/csswg-drafts#2000

wpt-commits: 4091ab0f7cbcb304cdd5b1d1c30264b052359b38
wpt-pr: 10233
wpt-commits: 4091ab0f7cbcb304cdd5b1d1c30264b052359b38
wpt-pr: 10233

UltraBlame original commit: 5b9ca0964cc4e29979c283b453faa08ffeb62226
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 2, 2019
…overflow properties, a=testonly

Automatic update from web-platform-tests[css-overflow-3] test the flow-relative overflow properties (#10233)

Corresponding to the spec changes decided in w3c/csswg-drafts#2000

wpt-commits: 4091ab0f7cbcb304cdd5b1d1c30264b052359b38
wpt-pr: 10233
wpt-commits: 4091ab0f7cbcb304cdd5b1d1c30264b052359b38
wpt-pr: 10233

UltraBlame original commit: 5b9ca0964cc4e29979c283b453faa08ffeb62226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Accepted by CSSWG Resolution Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-overflow-3 Current Work
Projects
None yet
Development

No branches or pull requests

7 participants