-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add audio and audio mixing #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My overall comment on the PR is not about the editing (I have minor comments/questions) but more about the complexity of the solution. We are leaving too many options: src vs source, fragment identifiers, external files vs embedded, base64 vs others, audio codecs, multiple sources .... I would prefer if we went for a simple solution first and then add more features.
In terms of editing, some comments:
- can we integrate section 5 inside 4.10 or move it as an Annex?
- the spec is starting to get big (47 pages!) The diagrams are taking a lot of space (and some of the open issues). I'm wondering if we should move the large diagrams to annexes.
* Describe syntax of data model diagram * Define audio recording properties * Define Mixing Instruction representation in TTML * Add placeholder for Audio Mixing section
Also change "defines" to "represents" in TTML representation sections.
…rofile content profile had been deleted accidentally in aa24e07
When the conformance is defined in TTML2 already, don't duplicate.
Also refer back to examples in the introduction where appropriate. Fix some linting issues.
Addresses #71.
No idea how that appeared.
36ecb05
to
35e9db3
Compare
I agree - the difficulty I have is in knowing which of the options to retain and which to omit. I want industry feedback so I have raised question issues about them. Seems to me that the best idea is to see what people want and need and remove everything else. |
I added an editorial note asking something similar! Done in f2d0194. |
In my view, that would not be an improvement. By closing open questions issues we will save some space, for sure. I'm not even sure that the length is a problem per se - I think we're targeting readability and conceptual explanations over length considerations. I just did a print to pdf preview and on my machine at A4 size it comes to 44 pages, of which 23 are the main body - data model, constraints and conformance, and they start on page 8. Everything from page 32 onwards is appendix. |
Closes #105 and #71.
<source>
element children of<audio>
Preview | Diff