Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audio and audio mixing #118

Merged
merged 27 commits into from
Mar 28, 2023
Merged

Add audio and audio mixing #118

merged 27 commits into from
Mar 28, 2023

Conversation

nigelmegitt
Copy link
Contributor

@nigelmegitt nigelmegitt commented Mar 17, 2023

Closes #105 and #71.

  • Add Audio, Synthesized Audio, Audio Recording and Mixing Instruction to the data model
  • Add informative section explaining audio mixing, with figures
  • Add extensions and apply constraints to content and processor profiles to support the required audio features
  • Reference "question" issues about the ways to reference or embed audio resources
  • Create the concept of "shared properties" and a subset of those that are "timing properties", so that Begin, End and Duration can be defined once and reused in all the classes where they apply
  • Fix some linting issues
  • Explain how extended descriptions can be implemented but are not specified
  • Define handling of multiple <source> element children of <audio>

Preview | Diff

Copy link
Contributor

@cconcolato cconcolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My overall comment on the PR is not about the editing (I have minor comments/questions) but more about the complexity of the solution. We are leaving too many options: src vs source, fragment identifiers, external files vs embedded, base64 vs others, audio codecs, multiple sources .... I would prefer if we went for a simple solution first and then add more features.

In terms of editing, some comments:

  • can we integrate section 5 inside 4.10 or move it as an Annex?
  • the spec is starting to get big (47 pages!) The diagrams are taking a lot of space (and some of the open issues). I'm wondering if we should move the large diagrams to annexes.

* Describe syntax of data model diagram
* Define audio recording properties
* Define Mixing Instruction representation in TTML
* Add placeholder for Audio Mixing section
Also change "defines" to "represents" in TTML representation sections.
…rofile

content profile had been deleted accidentally in aa24e07
When the conformance is defined in TTML2 already, don't duplicate.
Also refer back to examples in the introduction where appropriate.
Fix some linting issues.
No idea how that appeared.
@nigelmegitt nigelmegitt force-pushed the issue-0105-add-audio-mixing branch from 36ecb05 to 35e9db3 Compare March 28, 2023 09:46
@nigelmegitt
Copy link
Contributor Author

nigelmegitt commented Mar 28, 2023

We are leaving too many options: src vs source, fragment identifiers, external files vs embedded, base64 vs others, audio codecs, multiple sources .... I would prefer if we went for a simple solution first and then add more features.

I agree - the difficulty I have is in knowing which of the options to retain and which to omit. I want industry feedback so I have raised question issues about them. Seems to me that the best idea is to see what people want and need and remove everything else.

@nigelmegitt
Copy link
Contributor Author

  • can we integrate section 5 inside 4.10 or move it as an Annex?

I added an editorial note asking something similar! Done in f2d0194.

@nigelmegitt
Copy link
Contributor Author

  • the spec is starting to get big (47 pages!) The diagrams are taking a lot of space (and some of the open issues). I'm wondering if we should move the large diagrams to annexes.

In my view, that would not be an improvement. By closing open questions issues we will save some space, for sure. I'm not even sure that the length is a problem per se - I think we're targeting readability and conceptual explanations over length considerations.

I just did a print to pdf preview and on my machine at A4 size it comes to 44 pages, of which 23 are the main body - data model, constraints and conformance, and they start on page 8. Everything from page 32 onwards is appendix.

@nigelmegitt nigelmegitt merged commit b5376b4 into main Mar 28, 2023
@nigelmegitt nigelmegitt deleted the issue-0105-add-audio-mixing branch March 28, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add audio mixing into data model and TTML representation
2 participants