Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Allow role=slider on button and input type=button elements #444

Closed
scottaohara opened this issue Feb 1, 2023 · 0 comments · Fixed by #446
Closed

Update: Allow role=slider on button and input type=button elements #444

scottaohara opened this issue Feb 1, 2023 · 0 comments · Fixed by #446
Assignees
@scottaohara
Labels
Allowed roles Pertaining to the allowed roles of HTML elements

Comments

@scottaohara
Copy link
Member

scottaohara commented Feb 1, 2023 •
edited
Loading

Upon reviewing implementations for sliders which use a <button> element as its base, I have not been able to come up with any present-day reasoning as to why role=slider would not be allowed on a button. At least, not any reasoning that could not also be problematic under other testable situations / WCAG rules. E.g., if the button is given a preventDefault(), then the implicit functionality which would make this a problematic role allowance can be avoided - and that functional issue could be found via other manual checks.

proposed resolution: allow role=slider on the button element and input type=button|submit|reset|image.
@scottaohara scottaohara added the Allowed roles Pertaining to the allowed roles of HTML elements label Feb 1, 2023
@scottaohara scottaohara self-assigned this Feb 1, 2023
@scottaohara scottaohara changed the title Allow role=slider on button and input type=button elements Update: Allow role=slider on button and input type=button elements Feb 1, 2023
scottaohara added a commit that referenced this issue Feb 6, 2023
@scottaohara
Update button and input button allowances
52be13a 
closes #444
closes #395
closes #298

This PR makes the allowances for button-elements (button, input type=button|image|submit|reset) more consistent with each other.  Additionally, slider and gridcell are now listed under the allowed roles for these elements.

the LOE to properly create the necessary UX for some of these roles when specified, especially on the `input` type buttons, is rather large _but_ possible.  Any failures to not implement these properly would be caught by WCAG rules.  Allowing the roles won't change that.
@scottaohara scottaohara mentioned this issue Feb 6, 2023
Merged
4 tasks
scottaohara added a commit that referenced this issue Jul 5, 2023
@scottaohara
Update button and input button allowances (#446)
93d3476 
* Update button and input button type allowances

closes #444
closes #395
closes #298

This PR makes the allowances for button-elements (button, input type=button|image|submit|reset) more consistent with each other.  Additionally, slider and gridcell are now listed under the allowed roles for these elements.

the LOE to properly create the necessary UX for some of these roles when specified, especially on the `input` type buttons, is rather large _but_ possible.  Any failures to not implement these properly would be caught by other WCAG rules and likely other automated checks.

* add missing slider allowance for input type=image
* add changelog
@msereniti msereniti mentioned this issue Apr 4, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottaohara scottaohara

Labels
Allowed roles Pertaining to the allowed roles of HTML elements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update button and input button allowances w3c/html-aria
1 participant
@scottaohara