update stability text if there are multiple groups #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himorin
added a commit
to himorin/bikeshed-boilerplate
that referenced
this pull request
Mar 21, 2024
anssiko
reviewed
Mar 21, 2024
| ' A Candidate Recommendation Draft integrates changes from the previous Candidate Recommendation that the Working Group intends to include in a subsequent Candidate Recommendation Snapshot.'; | ||
| const groupIds = sr.getDelivererIDs(); | ||
| const INTRO_S = ` A Candidate Recommendation Snapshot has received wide review, is intended to gather implementation experience, and has commitments from Working Group${ | ||
| groupIds.length > 1 ? 's' : '' |
There was a problem hiding this comment.
Suggested change
| groupIds.length > 1 ? 's' : '' | |
| groupIds.length > 1 ? "s'" : '' |
Context: https://github.com/speced/bikeshed-boilerplate/pull/62/files#r1528428357
There was a problem hiding this comment.
@anssiko thanks for the suggestion. After checking with our head of comm, both versions appeared to be correct.
Now, the suggestion would also apply if there's a single group. So to avoid having to update both bikeshed and respec, I'm tempted to keep the current version of the sentence.
There was a problem hiding this comment.
Thanks for checking with comms folks. I'm fine with whatever is grammatically correct, so let's keep the current.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1818