From 3e379f973f06a9308467f115b3dca03d9375da52 Mon Sep 17 00:00:00 2001 From: Dominique Hazael-Massieux Date: Fri, 30 Aug 2024 14:59:34 +0200 Subject: [PATCH 1/3] Fix markup description of amendment 23 the elements marked by with the id didn't match across base-rec and webrtc; best described as an 'append' difftype in any case --- amendments.json | 3 ++- base-rec.html | 4 ++-- webrtc.html | 6 +++--- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/amendments.json b/amendments.json index 4cad0041e..73c93ac76 100644 --- a/amendments.json +++ b/amendments.json @@ -270,11 +270,12 @@ "id": 23 } ], - "rtcpeerconnectioniceevent-attributes": [ + "rtcpeerconnectioniceevent-url-desc": [ { "description": "Add deprecation notice to RTCPeerConnectionIceEvent.url", "pr": 2773, "testUpdates": "not-testable", + "difftype": "append", "type": "correction", "status": "candidate", "id": 23 diff --git a/base-rec.html b/base-rec.html index e68c70b3a..9ae47915b 100644 --- a/base-rec.html +++ b/base-rec.html @@ -7016,7 +7016,7 @@
-
+
Attributes
@@ -7041,7 +7041,7 @@
url of type DOMString, readonly, nullable
-

+

The url attribute is the STUN or TURN URL that identifies the STUN or TURN server used to gather this candidate. If the candidate was not gathered from a STUN or diff --git a/webrtc.html b/webrtc.html index f3cde540a..218e53dfe 100644 --- a/webrtc.html +++ b/webrtc.html @@ -6764,7 +6764,7 @@

Attributes

+ "RTCPeerConnectionIceEvent">
candidate of type {{RTCIceCandidate}}, readonly, nullable @@ -6788,14 +6788,14 @@

"idlAttrType">DOMString, readonly, nullable

-

+

The {{url}} attribute is the STUN or TURN URL that identifies the STUN or TURN server used to gather this candidate. If the candidate was not gathered from a STUN or TURN server, this parameter will be set to null.

-

+

This attribute is deprecated; it exists for legacy compatibility reasons only. Prefer the candidate {{RTCIceCandidate/url}}.

From 2c6a9a4c2a1309d8df8935357d7a69b3f71194f8 Mon Sep 17 00:00:00 2001 From: Dominique Hazael-Massieux Date: Fri, 30 Aug 2024 15:07:18 +0200 Subject: [PATCH 2/3] Remove duplicate entry in amendments --- amendments.json | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/amendments.json b/amendments.json index 73c93ac76..21f0f91f4 100644 --- a/amendments.json +++ b/amendments.json @@ -849,21 +849,6 @@ "id": 42 } ], - "setcodecpreferences-receive": [ - { - "description": "setCodecPreferences only takes into account receive codecs", - "pr": 2926, - "type": "correction", - "status": "candidate", - "tests": [ - "webrtc/RTCRtpTransceiver-setCodecPreferences.html" - ], - "testUpdates": [ - "web-platform-tests/wpt#44318" - ], - "id": 42 - } - ], "rtcrtpreceiver-receivecodecs": [ { "description": "Redefine SendCodecs and ReceiveCodecs", From 1bd3982db4c55f29b5fca543d5409f821007d30d Mon Sep 17 00:00:00 2001 From: Dominique Hazael-Massieux Date: Fri, 30 Aug 2024 15:28:00 +0200 Subject: [PATCH 3/3] Fix markup descriptions of amendments 31 and 47 --- amendments.json | 4 +--- base-rec.html | 6 +++--- webrtc.html | 6 +++--- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/amendments.json b/amendments.json index 21f0f91f4..e5c42fc1c 100644 --- a/amendments.json +++ b/amendments.json @@ -679,7 +679,7 @@ "id": 30 } ], - "setcodecparameters-algorithm": [ + "codecmatch-algorithm": [ { "description": "Fix ambiguities in the setCodecPreferences() algorithm", "pr": 2847, @@ -689,7 +689,6 @@ "testUpdates": "already-tested", "type": "correction", "status": "candidate", - "difftype": "append", "id": 31 }, { @@ -703,7 +702,6 @@ ], "type": "correction", "status": "candidate", - "difftype": "append", "id": 47 } ], diff --git a/base-rec.html b/base-rec.html index 9ae47915b..b88c83de8 100644 --- a/base-rec.html +++ b/base-rec.html @@ -11102,8 +11102,7 @@

When setCodecPreferences() in invoked, the user agent MUST run the following steps:

- -
    +

    1. Let transceiver be the RTCRtpTransceiver @@ -11174,7 +11173,8 @@

    -
    + +
    Note

    If set, the offerer's codec preferences will decide the order of the codecs in the offer. If the answerer does not have any diff --git a/webrtc.html b/webrtc.html index 218e53dfe..623efc545 100644 --- a/webrtc.html +++ b/webrtc.html @@ -6787,8 +6787,8 @@

    url of type DOMString, readonly, nullable -
    -

    +

    +

    The {{url}} attribute is the STUN or TURN URL that identifies the STUN or TURN server used to gather this candidate. If the candidate was not gathered from a STUN or @@ -11419,7 +11419,7 @@

-
+

The codec dictionary match algorithm given two {{RTCRtpCodec}} dictionaries first and second is as follows: