From 6df32ed0302dfdeeeeffab8a537aaeadaa55a13a Mon Sep 17 00:00:00 2001 From: Jan-Ivar Bruaroey Date: Wed, 16 Nov 2022 15:02:58 -0500 Subject: [PATCH 1/3] Remove maxFramerate like scaleResolutionDownBy for audio. --- webrtc.html | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/webrtc.html b/webrtc.html index 77abb8e59..cb518aac3 100644 --- a/webrtc.html +++ b/webrtc.html @@ -8140,8 +8140,10 @@

  • If kind is `"audio"`, remove the - {{RTCRtpEncodingParameters/scaleResolutionDownBy}} - member from all encodings that [=map/contain=] one. + {{RTCRtpEncodingParameters/scaleResolutionDownBy}} and + {{RTCRtpEncodingParameters/maxFramerate}} + members from all encodings that [=map/contain=] any of + them.

  • @@ -9622,7 +9624,10 @@

    "idlMemberType">double
    -

    When present, indicates the maximum frame rate that can be used to +

    + This member can only be present if the sender's kind is "video". + When present, indicates the maximum frame rate that can be used to send this encoding, in frames per second. The user agent is free to allocate bandwidth between the encodings, as long as the {{maxFramerate}} value is not exceeded.

    From dd72ce4cc71d7a4546999b3f584def83690cae59 Mon Sep 17 00:00:00 2001 From: Jan-Ivar Bruaroey Date: Wed, 16 Nov 2022 15:33:21 -0500 Subject: [PATCH 2/3] Hit setParameters as well as addTransceiver. --- webrtc.html | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/webrtc.html b/webrtc.html index cb518aac3..aebcf1dd0 100644 --- a/webrtc.html +++ b/webrtc.html @@ -8907,9 +8907,10 @@

  • If transceiver kind is `"audio"`, remove the - {{RTCRtpEncodingParameters/scaleResolutionDownBy}} - member from all encodings that - [=map/contain=] one. + {{RTCRtpEncodingParameters/scaleResolutionDownBy}} and + {{RTCRtpEncodingParameters/maxFramerate}} + members from all encodings that + [=map/contain=] any of them.

  • From 240b65fa452b278eee3e317e048e76dc36d5bd6e Mon Sep 17 00:00:00 2001 From: Jan-Ivar Bruaroey Date: Thu, 17 Nov 2022 17:16:41 -0500 Subject: [PATCH 3/3] Add amendments --- amendments.json | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/amendments.json b/amendments.json index 2c4d0ae15..015cf52d0 100644 --- a/amendments.json +++ b/amendments.json @@ -270,6 +270,13 @@ "type": "correction", "status": "candidate", "id": 20 + }, + { + "description": "Remove maxFramerate like scaleResolutionDownBy for audio", + "pr": 2799, + "type": "correction", + "status": "candidate", + "id": 24 } ], "setparameters-algo": [ @@ -293,6 +300,13 @@ "type": "addition", "status": "candidate", "id": 19 + }, + { + "description": "Remove maxFramerate like scaleResolutionDownBy for audio", + "pr": 2799, + "type": "correction", + "status": "candidate", + "id": 24 } ], "create-sender-algo": [