Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrayBuffer() should leave the stream locked #104

Closed
ricea opened this issue Mar 10, 2020 · 3 comments · Fixed by #173
Closed

arrayBuffer() should leave the stream locked #104

ricea opened this issue Mar 10, 2020 · 3 comments · Fixed by #173
Assignees

Comments

@ricea
Copy link
Contributor

ricea commented Mar 10, 2020

For consistency with Response arrayBuffer(), IncomingStream arrayBuffer() should leave the stream locked after it has finished reading.

@vasilvv
Copy link
Contributor

vasilvv commented Mar 18, 2020

Discussed at the meeting today. The conclusion is that we should not implement arrayBuffer() in the IncomingStream, and instead make sure that there is a uniform way to do .arrayBuffer()/.text()/.json() on any readably stream. Currently, new Response(stream).arrayBuffer() is a way to do that, but it's unclear if it has same performance properties; if not, we should address that (on spec and/or implementation level as appropriate).

@jan-ivar
Copy link
Member

jan-ivar commented Oct 21, 2020

Suggest postponing it until we have movement in the streams standard whatwg/streams#1019

@jan-ivar
Copy link
Member

Consensus to remove the incomingStream.arrayBuffer()

vasilvv added a commit to vasilvv/web-transport that referenced this issue Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants