Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove title id from static files #2014

Merged
merged 1 commit into from
May 15, 2024
Merged

remove title id from static files #2014

merged 1 commit into from
May 15, 2024

Conversation

egekorkan
Copy link
Contributor

fixes #1957

Future fixes will be at #2013

@danielpeintner
Copy link
Contributor

Note: this fixes the static HTML files. Anyhow, every time we re-generate the HTML with ReSpec we need to manually remove the automatically added id="title" for the header.

@lu-zero
Copy link
Contributor

lu-zero commented May 9, 2024

An alternative is to prefix all the id for the Thing elements with thing_ so we'd have thing_index.

@egekorkan
Copy link
Contributor Author

An alternative is to prefix all the id for the Thing elements with thing_ so we'd have thing_index.

I would move this discussion to #2013 . We cannot do that for 1.1 ontologies since that will break implementations

@lu-zero
Copy link
Contributor

lu-zero commented May 9, 2024

I mean have respec generate the anchor this way, not changing anything on our side.

@JKRhb
Copy link
Member

JKRhb commented May 15, 2024

This is just a very minor point, but would it make sense to keep some kind of id (like ontology-title, as @egekorkan suggested before, if I recall correctly) to still be able to link to the title? With no id at all, that would not be possible anymore (although you would probably not do so very often in the first place).

@JKRhb
Copy link
Member

JKRhb commented May 15, 2024

I mean have respec generate the anchor this way, not changing anything on our side.

If ReSpec (or Bikeshed?) was configurable in that way, that would probably be the ideal solution for this problem.

@egekorkan egekorkan merged commit 8eb1056 into main May 15, 2024
1 check passed
@egekorkan egekorkan deleted the ege-remove-titleid branch May 15, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

title reference is not correctly linked
4 participants